Skip to content

[New][Teams] Change places that control channel membership to reflect on team membership #21097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pierre-lehnen-rc merged 7 commits into from
Mar 15, 2021
Merged

[New][Teams] Change places that control channel membership to reflect on team membership #21097

pierre-lehnen-rc merged 7 commits into from
Mar 15, 2021

Conversation

@KevLehman
Copy link
Member

@KevLehman KevLehman commented Mar 12, 2021 •
edited
Loading

Proposed changes (including videos or screenshots)

  • Add teamMain property to rooms to identify the main team's room
  • Add roomId to team collection to facilitate search
  • Modify addOwner/removeOwner to reflect changes on TeamMember roles
  • Modify addUserToTeam to create a TeamMember entry on join
  • Modify addModerator/removeModerator to reflect changes
  • Modify addLeader/removeLeader to reflect changes

Issue(s)

Steps to test or reproduce

Further comments

@KevLehman
Add property to identify main team room
b5f8e93 
Create membership for users when they join main team channel

Propagate ownership modifications to the teammember instance
@KevLehman
Add missing types
1875719
@KevLehman KevLehman changed the base branch from develop to new/teams-back March 12, 2021 20:56
@KevLehman KevLehman requested a review from a team March 12, 2021 20:57
sampaiodiego
sampaiodiego requested changes Mar 15, 2021
View reviewed changes
@KevLehman KevLehman changed the title New/teams mainroom [New Mar 15, 2021
@KevLehman KevLehman changed the title [New [New][Teams] Change places that control channel membership to reflect on team membership Mar 15, 2021
@KevLehman KevLehman requested a review from a team March 15, 2021 14:14
@KevLehman KevLehman added feat:teams area: backend Touches the code on backend side labels Mar 15, 2021
@pierre-lehnen-rc pierre-lehnen-rc merged commit ec4869d into new/teams-back Mar 15, 2021
@pierre-lehnen-rc pierre-lehnen-rc deleted the new/teams-mainroom branch March 15, 2021 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sampaiodiego sampaiodiego sampaiodiego requested changes

@pierre-lehnen-rc pierre-lehnen-rc pierre-lehnen-rc approved these changes

Assignees

No one assigned

Labels

area: backend Touches the code on backend side

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KevLehman @sampaiodiego @pierre-lehnen-rc