Skip to content

Conversation

@tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Mar 10, 2021

Proposed changes (including videos or screenshots)

Avoids an undefined value to break a rendered attachment.

Issue(s)

Steps to test or reproduce

  1. Have a message with the following fields:
{
  ...
  "attachments": [{
    "collapsed": true,
    "title": "Title",
    "fields": [{
        "title": "Title"
    }]
  }]
}
  1. Click on expand/collapse button.

Further comments

@tassoevan tassoevan added this to the 3.12.2 milestone Mar 10, 2021
@tassoevan tassoevan requested a review from a team March 10, 2021 22:10
@tassoevan tassoevan marked this pull request as ready for review March 10, 2021 22:26
@ggazzo ggazzo merged commit ed442d0 into develop Mar 22, 2021
@ggazzo ggazzo deleted the fix/field-attachments branch March 22, 2021 23:48
@sampaiodiego sampaiodiego mentioned this pull request Apr 3, 2021
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants