[FIX] Stopping Jitsi reload #20973
Merged
[FIX] Stopping Jitsi reload #20973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagoevanp
approved these changes
Mar 4, 2021
Merged
sampaiodiego
pushed a commit
that referenced
this pull request
Mar 5, 2021
* removing dep from useMemo * Avoid missing dep in useMemo Co-authored-by: Tasso Evangelista <[email protected]>
sampaiodiego
pushed a commit
that referenced
this pull request
Mar 8, 2021
* removing dep from useMemo * Avoid missing dep in useMemo Co-authored-by: Tasso Evangelista <[email protected]>
sampaiodiego
pushed a commit
that referenced
this pull request
Mar 8, 2021
* removing dep from useMemo * Avoid missing dep in useMemo Co-authored-by: Tasso Evangelista <[email protected]>
vanhoang1107
pushed a commit
to vanhoang1107/Rocket.Chat
that referenced
this pull request
Mar 9, 2021
* rocketchat/master: Bump version to 3.12.1 [FIX] Missing spaces on attachment (RocketChat#21020) [IMPROVE] Close Call contextual bar after starting Jitsi call (RocketChat#21004) [FIX] Stopping Jitsi reload (RocketChat#20973)
gabriellsh
added a commit
that referenced
this pull request
Mar 29, 2021
…s/remove_user * 'develop' of github.com:RocketChat/Rocket.Chat: Regression: When only 'teams' type is provided, show only rooms with teamMain on rooms.adminRooms endpoint (#21322) [FIX] 'Chats in Progress' Section is not rendering when the routing algorithm is not Manual Selection (#21324) Bump version to 3.12.2 Bump version to 3.12.1 [FIX] Missing spaces on attachment (#21020) [IMPROVE] Close Call contextual bar after starting Jitsi call (#21004) [FIX] Stopping Jitsi reload (#20973)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
The Function where Jitsi call is started gets called many times due to
room.usernamesdep of useMemo, this dep triggers reloading of this function many times.So removing this dep from useMemo dependencies
Issue(s)
fixes #20946
Steps to test or reproduce
Further comments
I am not sure if this is the correct way to do it, But I checked that
room.usernamestriggers the useMemo many times, even though room.usernames is not being changed. I am not sure why is it so. Will look into it more, meanwhile this will fix broken jitsi calls