Skip to content

Chore: Remove new Buffer in favor of Buffer.from #20918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sampaiodiego merged 1 commit into from
Mar 10, 2021
Merged

Chore: Remove new Buffer in favor of Buffer.from #20918

sampaiodiego merged 1 commit into from
Mar 10, 2021

Conversation

@KevLehman
Copy link
Member

@KevLehman KevLehman commented Feb 26, 2021

Proposed changes (including videos or screenshots)

  • Changes new Buffer to Buffer.from since the first one is deprecated.

Issue(s)

Steps to test or reproduce

Further comments

@KevLehman KevLehman added the area: backend Touches the code on backend side label Feb 26, 2021
@sampaiodiego sampaiodiego changed the title [CHORE] Remove new Buffer in favor of Buffer.from Chore: Remove new Buffer in favor of Buffer.from Mar 10, 2021
@sampaiodiego sampaiodiego merged commit 31552ca into develop Mar 10, 2021
@sampaiodiego sampaiodiego deleted the remove-new-buffer branch March 10, 2021 20:00
gabriellsh added a commit that referenced this pull request Mar 15, 2021
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into new/…
77ff283 
…teams

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Chore: Meteor update 2.1 (#21061)
  Improve: Increase testing coverage (#21015)
  Add AWS region to CI
  Chore: Add tests for Meteor methods (#20901)
  Chore: Remove `new Buffer` in favor of `Buffer.from` (#20918)
@sampaiodiego sampaiodiego mentioned this pull request Apr 3, 2021
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

Assignees

No one assigned

Labels

area: backend Touches the code on backend side

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KevLehman @sampaiodiego