Skip to content

Conversation

@yash-rajpal
Copy link
Member

@yash-rajpal yash-rajpal commented Feb 22, 2021

  • I have read the Contributing Guide
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

Added hide unread counter check, if the show unread messages is turned off, now unread messages badge won't be shown to user.

Issue(s)

fixes #20866

Steps to test or reproduce

Further comments

##Before
Even after turning off unread counter, it showed unread counter on room list.
unread status before

##After
Now added check before showing unread messages badge. If option to show counter is turned off, unread badge won't be shown.
unread status after

@yash-rajpal
Copy link
Member Author

@ggazzo @dougfabris Please Review. :)

@yash-rajpal
Copy link
Member Author

@dougfabris Please review, adding a left out permission here.
Thanks :)

@ggazzo ggazzo merged commit 3d6cd21 into RocketChat:develop Mar 22, 2021
@sampaiodiego sampaiodiego mentioned this pull request Apr 3, 2021
13 tasks
@danieltche
Copy link

Hi everyone.
I'm missing this feature now. There are some discussion groups that I don't want notification desktop, but I want to know about new messages. Before this issue, this was possible because there was a counter of unread messages in the group. But now, it don´t show anything in Windows aplication and Web. In the Android app this still works.
Is it possible a new configuration to show a counter of unread messages in groups but without desktop notifications?
Thanks

@dougfabris
Copy link
Member

dougfabris commented Apr 26, 2021

@danieltche Could you create an issue, reporting the problem you're facing, please?

@yash-rajpal
Copy link
Member Author

@danieltche Can you Please elaborate on your issue and open an issue so that we can work on that.

This PR introduces a show counter check, if that is off, you would not see the counter infront of that room name.
The setting is present under Notification Preferences.
image

If you turn off this setting, you would not see any counter infront of room names. If you want to see this number, you can turn on this setting.

Maybe I am gettings this wrong, please provide some more information on desired behaviour. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'Show unread counter' setting is not implemented in room list

4 participants