Skip to content

Conversation

@Darshilp326
Copy link
Contributor

@Darshilp326 Darshilp326 commented Feb 13, 2021

Proposed changes (including videos or screenshots)

Reactions list shows emojis with respected users who have reacted with that emoji.

reactions-list-pr.mp4

Issue(s)

Closes #20752
Closes #21002

Steps to test or reproduce

Further comments

@Darshilp326
Copy link
Contributor Author

Screenshot from 2021-02-14 02-07-28

Does it look better than the one in that PR video?
As users need to scroll less. 🙂

@Darshilp326
Copy link
Contributor Author

@ggazzo @dougfabris Please review 😄

@dougfabris
Copy link
Member

@ggazzo @dougfabris Please review 😄

I made some fix changing the approach. Thanks!

@dougfabris dougfabris added the stat: ready to merge PR tested and approved waiting for merge label Mar 4, 2021
@dougfabris dougfabris requested a review from ggazzo March 4, 2021 19:38
@dougfabris dougfabris requested review from a team and removed request for ggazzo March 16, 2021 14:29
@ggazzo ggazzo merged commit dcdb845 into RocketChat:develop Mar 22, 2021
@sampaiodiego sampaiodiego mentioned this pull request Apr 3, 2021
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The Reactions option doesnt show who have reacted what emoji on the message Reactions list in message actions renders blank.

4 participants