Skip to content

Conversation

@aKn1ghtOut
Copy link
Contributor

@aKn1ghtOut aKn1ghtOut commented Feb 12, 2021

Proposed changes (including videos or screenshots)

The $().data function was returning outdated values for re-assigned emoji buttons with new data. Changed that to use the .attr() function. This works perfectly.

Issue(s)

Closes #20734

Steps to test or reproduce

  1. React to a message
  2. React to the same message again using a different reaction
  3. Click the first reaction. It disappears.
  4. Click the only remaining reaction. The first reaction reappears.

Further comments

@yash-rajpal
Copy link
Member

This works like a charm.

@ggazzo ggazzo merged commit 6e06c86 into RocketChat:develop Mar 22, 2021
@sampaiodiego sampaiodiego mentioned this pull request Apr 3, 2021
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reactions (inline) are behaving weird

3 participants