[FIX] Save user password and email from My Account #20737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampaiodiego
requested review from
Ishrat-Manzoor,
ggazzo,
pierre-lehnen-rc and
rodrigok
sampaiodiego
force-pushed
the
fix-set-user-password
branch
from
d40457f to
5a476d2
Compare
Contributor
|
Great to see this fix, as it is really security related, if users can not change their passwords. Also other profile settings (email, avatar image etc) could not be changed. |
KevLehman
reviewed
Feb 17, 2021
| const canChangePasswordForOAuth = rcSettings.get('Accounts_AllowPasswordChangeForOAuthUsers'); | ||
| if (canChangePasswordForOAuth || user.services?.password) { | ||
| // Should be the last check to prevent error when trying to check password for users without password | ||
| if (settings.newPassword && rcSettings.get('Accounts_AllowPasswordChange') === true) { |
Member
There was a problem hiding this comment.
We can remove the === true part of this
Member
Author
There was a problem hiding this comment.
yep, this is an old code that was just re-indented, but I agree 👍
Ishrat-Manzoor
previously approved these changes
Feb 17, 2021
ggazzo
approved these changes
Feb 18, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Closes #19604
Steps to test or reproduce
Further comments