Skip to content

Conversation

@yash-rajpal
Copy link
Member

@yash-rajpal yash-rajpal commented Feb 12, 2021

  • I have read the Contributing Guide
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

Burger was not visible on a certain width, specifically between 600 to 780. if width is more than 780px sidebar is shown, if less than 600 then burger icon was shown. But it wasn't shown between 600px to 780 px.
It was because for showing burger icon we were only checking for isMobile which is lenght only less than 600. So i added one more check for condition if length is less than 780 px.

Issue(s)

fixes #20499 #20859

Steps to test or reproduce

Further comments

Earlier

fix-burger-earlier

After

fix-burger-after

@yash-rajpal
Copy link
Member Author

@ggazzo @MartinSchoeler Please review. :)

@yash-rajpal
Copy link
Member Author

@ggazzo @MartinSchoeler Please review. :)

@yash-rajpal
Copy link
Member Author

@dougfabris Please have a look. Thanks :)

@yash-rajpal
Copy link
Member Author

@ggazzo please review.

@ghost
Copy link

ghost commented Apr 20, 2021

I really hope the fix will be merged soon. This is indeed a quite annoying UI-problem.

@yash-rajpal
Copy link
Member Author

@ggazzo Please have a look at this :)

dougfabris
dougfabris previously approved these changes Apr 20, 2021
@dougfabris dougfabris added the stat: ready to merge PR tested and approved waiting for merge label Apr 20, 2021
@yash-rajpal
Copy link
Member Author

Ohh, I didn't notice the conflicts, will resolve in sometime.
Thanks @dougfabris , Sorry for tagging on a conflicting PR.

@dougfabris dougfabris requested a review from ggazzo April 22, 2021 19:44
@ggazzo ggazzo merged commit c03e4a4 into RocketChat:develop May 10, 2021
@sampaiodiego sampaiodiego mentioned this pull request May 28, 2021
@tpat2
Copy link

tpat2 commented Jun 2, 2021

Thank you for working on this.
I'm testing on 3.15.0, this works when I'm on a channel, but doesn't seem to work when I'm on a direct message.

@yash-rajpal
Copy link
Member Author

Hello @tpat2 #22211 will fix the burger menu on Direct messages :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hamburger button to show hidden sidebar missing at certain window width

4 participants