-
Notifications
You must be signed in to change notification settings - Fork 13.1k
[FIX] Visibility of burger menu on certain width #20736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@ggazzo @MartinSchoeler Please review. :) |
|
@ggazzo @MartinSchoeler Please review. :) |
|
@dougfabris Please have a look. Thanks :) |
|
@ggazzo please review. |
|
I really hope the fix will be merged soon. This is indeed a quite annoying UI-problem. |
|
@ggazzo Please have a look at this :) |
|
Ohh, I didn't notice the conflicts, will resolve in sometime. |
|
Thank you for working on this. |
Proposed changes (including videos or screenshots)
Burger was not visible on a certain width, specifically between 600 to 780. if width is more than 780px sidebar is shown, if less than 600 then burger icon was shown. But it wasn't shown between 600px to 780 px.
It was because for showing burger icon we were only checking for
isMobilewhich is lenght only less than 600. So i added one more check for condition if length is less than 780 px.Issue(s)
fixes #20499 #20859
Steps to test or reproduce
Further comments
Earlier
After