Skip to content

Conversation

@KevLehman
Copy link
Member

Proposed changes (including videos or screenshots)

  • Unread messages count won't be incremented when the message sent is on a thread (thread count is treated different)

Issue(s)

  • No open issue.
  • Issue description: when a user answers a direct message by answering in a thread, the unread counter next to user's name will mark 2 instead of 1.

Steps to test or reproduce

  • Start a direct conversation with another person
  • After the first message from the other one, instead of answering to the main conversation, write your reply in a thread\
  • The other person will see a badge of 2 unread messages instead of 1 (since we sent just one message)

Further comments

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Kevin Aleman seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sampaiodiego sampaiodiego changed the title [FIX] Dont update unread count when the message is a thread [FIX] Increasing unread counter twice for new threads in DMs or with mentions Feb 18, 2021
@sampaiodiego sampaiodiego merged commit 65c05de into develop Feb 18, 2021
@sampaiodiego sampaiodiego deleted the fix-thread-unread-count branch February 18, 2021 14:51
@sampaiodiego sampaiodiego mentioned this pull request Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants