[FIX] Event emitter warning #20663
Merged
[FIX] Event emitter warning #20663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshMcCullough
suggested changes
Feb 11, 2021
Contributor
JoshMcCullough
left a comment
JoshMcCullough
left a comment
There was a problem hiding this comment.
Please remove commented console.log lines.
Member
Author
will do @JoshMcCullough , thanks 🤗 .. PR is still in draft.. I fixed a memory leak already but that will not solve the issue, so I'm still planning to use a different package as the Event Emitter solution. |
rodrigok
approved these changes
Feb 18, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
The current fix are only 5cf7542 and 4adb5b1
Issue(s)
Closes #19065
Steps to test or reproduce
Further comments