Rewrite: CreateChannel modal component #20617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabriellsh
reviewed
Feb 5, 2021
gabriellsh
requested changes
Feb 5, 2021
Member
gabriellsh
left a comment
gabriellsh
left a comment
There was a problem hiding this comment.
Only thing I noticed is that whenever I create a new channel, if I mark it as public && broadcast, it creates a readonly channel, but not a broadcast one. If I create it as a private group, it is created as broadcast.
….Chat into rewrite/create-channel
ggazzo
changed the title
gabriellsh
previously approved these changes
Feb 8, 2021
ggazzo
approved these changes
Feb 9, 2021
6 tasks
Member
|
@ggazzo @tiagoevanp Please see issue #20771 Please review PR #20772 , this PR adds back this template. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments