[FIX] Default Attachments - Show Full Attachment.Text with Markdown

[aditya-mitra]

Proposed changes (including videos or screenshots)

Removed truncating of text in Attachment.Text.
Added Attachment.Text to be parsed to markdown by default.

Earlier

Now

Issue(s)

Closes #20560

Steps to test or reproduce

#20560 (comment) shows the bug which can be reproduced by using the cURL command if you already have a bot with the correct credentials.

Otherwise you can use this way to reproduce the message, (I have used a bot for that):

1. On the terminal, do git clone https://github.com/aditya-mitra/rocketchatbot.git && cd rocketchatbot && git checkout reproducing-issue-md && npm install (this will clone the repo and install dependencies)
2. Add this bot with these username and password to the list of users. (For reference, you can see this - https://www.freecodecamp.org/news/how-to-build-a-rocketchat-bot-with-typescript/#how-to-set-up-a-bot-account-in-rocket-chat)
3. Now in the terminal where you cloned the repo for the bot, do npm start.
4. You will get a message in the general channel of your running instance.

Further comments

[fdellwing]

Unrelated to the PR, you do not need to setup an own bot. RC comes with the rocket.cat bot on board.

[aditya-mitra]

Thanks for pointing that out :D
I guess that will be easier setup.

[fdellwing]

I'll try to test this tomorrow. It's a bit complicated in our 3 instances docker-compose setup, but should work.

[yash-rajpal]

LGTM.

[fdellwing]

Seems to fix the issue 👍

[danielpotthast]

Why isn't this fix already merged in 3.11.1?

[Exordian]

Emojis and linebreaks are still broken. Yet, Markdown and full size work fine again