Skip to content

Conversation

@joshi008
Copy link
Contributor

@joshi008 joshi008 commented Jan 28, 2021

Fix Documentation:

Proposed changes

The link for documentation in the readme was previously https://rocket.chat/docs/ while that was not working and according to the website it was https://docs.rocket.chat/
The link for deployment methods in readme was corrected from https://rocket.chat/docs/installation/paas-deployments/ to https://docs.rocket.chat/installation/paas-deployments
Some more links to the documentations were giving 404 error which hence updated.

Issue(s)

The link was not correct for documentation in the readme.

Steps to test or reproduce

This requires no test

Further comments

Closes #20525

The link was previously https://rocket.chat/docs/ while that was not working and according to the website it was https://docs.rocket.chat/
@CLAassistant
Copy link

CLAassistant commented Jan 28, 2021

CLA assistant check
All committers have signed the CLA.

@joshi008 joshi008 changed the title Corrected the link to documentation of rocket.chat [IMPROVE] Corrected the link to documentation of rocket.chat Jan 28, 2021
Paas Deployment Documentation link corrected
Documentation links correction
@joshi008 joshi008 changed the title [IMPROVE] Corrected the link to documentation of rocket.chat [IMPROVE] Corrected the link to documentation of rocket.chat README.md Jan 29, 2021
@joshi008 joshi008 changed the title [IMPROVE] Corrected the link to documentation of rocket.chat README.md Doc: Corrected the link to documentation of rocket.chat README.md Jan 29, 2021
@joshi008
Copy link
Contributor Author

joshi008 commented Jan 29, 2021

Could anyone please review it and tell if the links are correct or not.
Not tagging anyone because you might be busy in some serious issue.
Just a help to make readme better :)

@joshi008 joshi008 changed the title Doc: Corrected the link to documentation of rocket.chat README.md Doc: Corrected the link to documentation of rocket.chat README.md #20525 Jan 31, 2021
@joshi008 joshi008 changed the title Doc: Corrected the link to documentation of rocket.chat README.md #20525 Doc: Corrected the link to documentation of rocket.chat README.md Jan 31, 2021
@joshi008 joshi008 changed the title Doc: Corrected the link to documentation of rocket.chat README.md Doc: Corrected links to documentation of rocket.chat README.md Jan 31, 2021
Copy link
Member

@KevLehman KevLehman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@KevLehman
Copy link
Member

Can you please update your base branch with the tip of develop? Thanks!

@joshi008
Copy link
Contributor Author

joshi008 commented Feb 4, 2021

Can you please update your base branch with the tip of develop? Thanks!

Thanks for reviewing @KevLehman . I have updated the branch with develop branch.

@sampaiodiego sampaiodiego merged commit 9b5b915 into RocketChat:develop Apr 5, 2021
@sampaiodiego sampaiodiego mentioned this pull request Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Doc: Links to documentation is not correct in the README.md file

4 participants