[FIX] Add tooltips to Thread header buttons #20456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggazzo
requested changes
Feb 2, 2021
Comment on lines
72
to
74
| {hasExpand && <VerticalBar.Action title={t('Expand')} aria-label={expandLabel} name={expandIcon} onClick={handleExpandActionClick} />} | ||
| <VerticalBar.Actions> | ||
| <VerticalBar.Action aria-label={followLabel} name={followIcon} onClick={handleFollowActionClick} /> | ||
| <VerticalBar.Action title={t(following ? 'Unfollow_message' : 'Follow_message')} aria-label={followLabel} name={followIcon} onClick={handleFollowActionClick} /> |
Member
There was a problem hiding this comment.
you can use the value applied on the aria-label, and since you are using title, no need to use aria please remove ;)
ggazzo
approved these changes
Feb 11, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Proposed changes (including videos or screenshots)
Added tooltips to "Expand" and "Follow Message"/"Unfollow Message" in ThreadView for coherency.
Issue(s)
Closes #20455
Steps to test or reproduce
Further comments