Skip to content

Conversation

@aKn1ghtOut
Copy link
Contributor

Checklist

  • I have read the Contributing Guide
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

When setting 'Message_ShowDeletedStatus' is set to true, deleting a message with tshow: true causes a bug on the frontend. This issue should, however, never be logically possible as a 'removed' message should not have tshow anyway. Hence, this PR unsets that when the message is set to "Message Removed".

Issue(s)

Closes #20443

Steps to test or reproduce

  1. Set setting 'Message_ShowDeletedStatus' to true
  2. Send a message. [ Message A ]
  3. Send a message in the same room after it.
  4. Reply to Message A. [ Reply B ]
  5. Send another message in the room(not thread).
  6. Delete reply B.
  7. Empty hoverable box appears where reply B was placed.

Screenshot from 2021-01-27 19-52-09

Further comments

@ggazzo ggazzo merged commit 15177a3 into RocketChat:develop Feb 2, 2021
@sampaiodiego sampaiodiego mentioned this pull request Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Deleting first reply in a thread leaves unwanted remnant

2 participants