Skip to content

[FIX] Empty URL in user avatar doesn't show error and enables save #20440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rodrigok merged 7 commits into from
Mar 23, 2021
Merged

[FIX] Empty URL in user avatar doesn't show error and enables save #20440

Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c7d58df
Update UserAvatarEditor.js
im-adithya Jan 27, 2021
21c3511
Update UserAvatarEditor.js
im-adithya Jan 27, 2021
b4e4a66
Update UserAvatarEditor.js
im-adithya Jan 27, 2021
c7ca103
Update UserAvatarEditor.js
im-adithya Jan 27, 2021
6120045
Update UserAvatarEditor.js
im-adithya Feb 12, 2021
d6f5c4b
Merge branch 'develop' into empty-useravatar
Feb 25, 2021
2e3c0be
add url field validation
Feb 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions client/components/avatar/UserAvatarEditor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
import React, { useState, useCallback } from 'react';
import { Meteor } from 'meteor/meteor';
import toastr from 'toastr';
import { Box, Button, Icon, TextInput, Margins, Avatar } from '@rocket.chat/fuselage';

import { useTranslation } from '../../contexts/TranslationContext';
Expand Down Expand Up @@ -40,6 +42,10 @@ export function UserAvatarEditor({ currentUsername, username, setAvatarObj, sugg
const [clickUpload] = useFileInput(setUploadedPreview);

const clickUrl = () => {
if (avatarFromUrl === '') {
toastr.error('Please Enter a URL');
throw new Meteor.Error();
}
Comment thread
dougfabris marked this conversation as resolved.
setNewAvatarSource(avatarFromUrl);
setAvatarObj({ avatarUrl: avatarFromUrl });
};
Expand Down