Skip to content

Conversation

@yash-rajpal
Copy link
Member

  • I have read the Contributing Guide -
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

Announcements with multiple lines used to break UI for announcements bar. Fixed it by replacing all break lines in announcement with empty space (" ") . The announcement modal would work as usual and show all break lines.

Issue(s)

fixes #20380

Steps to test or reproduce

check issue.

Further comments

image
image

@ggazzo ggazzo requested a review from dougfabris January 30, 2021 03:00
@ggazzo ggazzo merged commit f0073e7 into RocketChat:develop Feb 8, 2021
@dougfabris dougfabris changed the title [FIX] Announcements with multiple lines fixed. [FIX] Announcement with multiple lines fixed. Feb 18, 2021
@sampaiodiego sampaiodiego mentioned this pull request Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiple lines announcements breaks UI

3 participants