[FIX]Selected hide system messages would now be viewed in vertical bar. #20358
Conversation
MartinSchoeler
left a comment
MartinSchoeler
left a comment
There was a problem hiding this comment.
Requested some changes.
Tip: try out a bit with the maxWidth property
Thanks!
client/views/room/contextualBar/Info/EditRoomInfo/EditRoomInfo.js
Outdated
Show resolved
Hide resolved
|
@MartinSchoeler Working! |
System-messages-changes.mp4@MartinSchoeler Please review:) |
MartinSchoeler
left a comment
MartinSchoeler
left a comment
There was a problem hiding this comment.
Looking way better! Let me give you another tip for making this PR perfect:
Almost all of our components can receive css properties directly as props, you only need to camel case the css property name, e.g. <Element maxWidth='100%'></Element> with this Rocket.Chat is creating CSS rules at runtime and squeezing a little bit more performance out of its components, also this is the pattern that we are following with our React Components.
If you want to know more, you can check our Components documentation (we call it 'Fuselage').
|
@MartinSchoeler Done! |
|
@MartinSchoeler Please review:) |
3 participants
Proposed changes (including videos or screenshots)
All selected hide system messages are now in vertical Bar.
system-message-issue.mp4
Issue(s)
Closes #20357
Steps to test or reproduce
Further comments