Skip to content

Conversation

@yash-rajpal
Copy link
Member

  • I have read the Contributing Guide
  • I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

Able to Empty the highlighted text field in preferences

Issue(s)

fixes #20328

Steps to test or reproduce

Further comments

after-highlights
The spelling of highlights was wrong due to which error was coming

@yash-rajpal
Copy link
Member Author

@ggazzo @MartinSchoeler Please review. This is just a typo in a variable name, which gives error.

Copy link
Member

@MartinSchoeler MartinSchoeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@ggazzo ggazzo merged commit 4e93da4 into RocketChat:develop Feb 8, 2021
@sampaiodiego sampaiodiego mentioned this pull request Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FIX] Unable to empty Highlighted words in Preferences

3 participants