Skip to content

[FIX] Added Bio Structure for UserCard, rendering Skeleton View on loading Instead of [Object][Object] #20305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggazzo merged 5 commits into from
Feb 2, 2021
Merged

[FIX] Added Bio Structure for UserCard, rendering Skeleton View on loading Instead of [Object][Object] #20305

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
de4d72a
Added Bio Structure
yash-rajpal Jan 21, 2021
62710f8
added case if bio is null
yash-rajpal Jan 21, 2021
12bc9b1
removing console log
yash-rajpal Jan 21, 2021
04840e9
lint fixes
yash-rajpal Jan 21, 2021
afaa068
requested changes, simplified logic
yash-rajpal Jan 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions client/components/UserCard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,8 @@ const UserCard = forwardRef(({
<Skeleton width='32%' mi='x2'/>
<Skeleton width='32%' mi='x2'/>
</>,
bio = <>
bio,
bioStructure = <>
<Skeleton width='100%'/>
<Skeleton width='100%'/>
<Skeleton width='100%'/>
Expand All @@ -81,7 +82,7 @@ const UserCard = forwardRef(({
{ customStatus && <Info>{customStatus}</Info> }
<Roles>{roles}</Roles>
<Info>{localTime}</Info>
{ bio && <Info withTruncatedText={false} style={clampStyle} height='x60'><MarkdownText content={bio}/></Info> }
{bio !== undefined ? bio && <Info withTruncatedText={false} style={clampStyle} height='x60'><MarkdownText content={bio}/></Info> : <Info withTruncatedText={false} style={clampStyle} height='x60'>{bioStructure}</Info>}

@MartinSchoeler MartinSchoeler Jan 22, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe instead of doing this ternary, we can check the type of the bio variable inside of the info element?

{open && <a onClick={open}>{t('See_full_profile')}</a>}
</Box>
{onClose && <Box><ActionButton ghost icon='cross' onClick={onClose}/></Box>}
Expand Down