[FIX] Saving with blank email in edit user #20259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@RonLek Hey! Thanks for your help. I think it's nice to have either a UI verification on the email field blocking to send the form if the user leaves it blank. Are you interested to improve it? |
RonLek
force-pushed
the
fix_blank_email_user_edit
branch
from
8fadcd1 to
c245b91
Compare
Contributor
Author
|
@dougfabris Thanks! Made changes to disable the Save button on blank email thereby preventing the unnecessary |
ggazzo
approved these changes
Jan 21, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Disallows showing a success popup when email field is made blank in Edit User and instead shows the relevant error popup.
Screencast.from.Tuesday.19.January.2021.01.44.53.IST.mp4
Issue(s)
Closes #20258
Steps to test or reproduce