-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] User's Custom Status to be displayed in Direct Chat #20257
[FIX] User's Custom Status to be displayed in Direct Chat #20257
Conversation
@ggazzo Can you please review :D |
Is this reactive? E.g. if someone updates their status, does it update automatically or do you have to refresh the room? |
@wreiske But, the his online/offline status is reactive. I could not find an implementation of reactive user custom status text in the client folder. |
My original implementation before the switch to react was reactive. I would say anywhere a status message shows (top of room, inside user popup, sidebar, etc.) It should be reactive and update when the user updates their status. |
@wreiske Can you please point out (or share) your implementation? |
The original PRs: Specifically the room headers: https://github.com/RocketChat/Rocket.Chat/pull/14853/files#diff-b200b9e23149e92470df6e0b1601a6b817f472d95764df95301388ed6c992df4 Thanks for your help @aditya-mitra ! |
1c8bf28
to
bfef09d
Compare
@wreiske I made the user status text reactive!. I used another hook I have also made a short video to demonstrate it working. live-user-status-text-2.mp4 |
@ggazzo Can you please review :D |
@ggazzo Are some more changes required? |
Closing this in favour of #20593 . |
Proposed changes (including videos or screenshots)
In a 2-person direct message, the status of the other user could not be seen in the Header.
It has been fixed by fetching the user's status-text in a 2-person direct message room.
Issue(s)
Closes #20197
Steps to test or reproduce
Same as mentioned in #20197
Further comments
The status-text of the user (who you are chatting with in direct message) can be shown as the room topic.
Room Topics are unaffected by this change.
Displaying the status text in the header is more convenient than click on the user to find his/her status.