[FIX]Added success message on saving notification preference. #20220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@Darshilp326 We should have a way to check if everything works well with |
Contributor
Author
|
@dougfabris Error messages are already dispatching. |
Member
|
@Darshilp326 Nice! I'm going to accept the PR and it probably will be merged ASAP. Thanks for the help mate! |
dougfabris
approved these changes
Jan 18, 2021
Contributor
Author
|
@dougfabris Looking forward to more such prs:) |
ggazzo
approved these changes
Jan 19, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Added success message after saving notification preferences.
notification-preference-pr.mp4
Issue(s)
Fixes #20219
Steps to test or reproduce
Further comments