[IMPROVE] Adds toast after follow/unfollow messages and following icon for followed messages without threads. #20025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…owed no-thread messages Fixes lint
RonLek
changed the title
Contributor
Author
|
@ggazzo @tassoevan could one of you please review this one? : ) |
Contributor
Author
|
@ggazzo @tassoevan any pointers? Please do let me know if anything needs to change. Thanks : ) |
ggazzo
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
There was no alert on following/unfollowing a message previously. Also, it was impossible to make out a followed message with no threads from an unfollowed one.
This PR would show an alert on following/unfollowing a message and also display a small bell icon (similar to the ones for starred and pinned messages) when a message with no thread is followed.
Screencast.from.Saturday.02.January.2021.12_58_33.IST.mp4
Issue(s)
Fixes #20024
Steps to test or reproduce
Further comments
When the followed message (currently with no thread) gets a thread, the smaller bell icon should disappear (since we already show a larger bell icon for messages with threads). This PR tackles that case as well :)