Regression: Check permissions properly when fetching rooms in Omnichannel Directory #19951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs can see all chats.
renatobecker
changed the title
renatobecker
changed the title
renatobecker
approved these changes
Dec 26, 2020
Merged
vanhoang1107
pushed a commit
to vanhoang1107/Rocket.Chat
that referenced
this pull request
Dec 29, 2020
* rocketchat/master: (92 commits) Bump version to 3.10.0 Bump version to 3.10.0-rc.4 Revert "[NEW] Storj integration (RocketChat#19932)" Bump version to 3.10.0-rc.3 Regression: polishing licenses endpoints (RocketChat#19981) Regression: Double Scrollbars on tables (RocketChat#19980) Regression: Add currently running instance to instances.get endpoint (RocketChat#19955) Bump version to 3.10.0-rc.2 Regression: Fix sorting indicators on Admin Users page (RocketChat#19950) Regression: Fix oembed (RocketChat#19978) [FIX] Status on searchlist (RocketChat#19935) [FIX] Omnichannel Departments Canned Responses (RocketChat#19830) Regression: Check permissions properly when fetching rooms in Omnichannel Directory (RocketChat#19951) Regression: Add missing translations on the Omnichannel Contact Center(Directory) (RocketChat#19968) Regression: Header Styles fixes (RocketChat#19946) [FIX] Room scrolling to top after returns to a opened room (RocketChat#19945) Bump version to 3.10.0-rc.1 Omnichannel Custom Fields router name was wrong. (RocketChat#19948) Regression: UserCard "See full profile" link broken (RocketChat#19941) Regression: Admin Sidebar Scroll (RocketChat#19944) ...
vanhoang1107
pushed a commit
to vanhoang1107/Rocket.Chat
that referenced
this pull request
Dec 29, 2020
* rocketchat/master: (92 commits) Bump version to 3.10.0 Bump version to 3.10.0-rc.4 Revert "[NEW] Storj integration (RocketChat#19932)" Bump version to 3.10.0-rc.3 Regression: polishing licenses endpoints (RocketChat#19981) Regression: Double Scrollbars on tables (RocketChat#19980) Regression: Add currently running instance to instances.get endpoint (RocketChat#19955) Bump version to 3.10.0-rc.2 Regression: Fix sorting indicators on Admin Users page (RocketChat#19950) Regression: Fix oembed (RocketChat#19978) [FIX] Status on searchlist (RocketChat#19935) [FIX] Omnichannel Departments Canned Responses (RocketChat#19830) Regression: Check permissions properly when fetching rooms in Omnichannel Directory (RocketChat#19951) Regression: Add missing translations on the Omnichannel Contact Center(Directory) (RocketChat#19968) Regression: Header Styles fixes (RocketChat#19946) [FIX] Room scrolling to top after returns to a opened room (RocketChat#19945) Bump version to 3.10.0-rc.1 Omnichannel Custom Fields router name was wrong. (RocketChat#19948) Regression: UserCard "See full profile" link broken (RocketChat#19941) Regression: Admin Sidebar Scroll (RocketChat#19944) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
view-livechat-roomspermissions is supposed to give permission for managers to see all chats from all agents, so I changed the API endpoint and Chat tab in Omnichannel Contact Center.view-livechat-roomscan see all rooms.view-l-roomcan see rooms assigned to your user.Issue(s)
Steps to test or reproduce
Further comments