[IMPROVE] Adds tooltip for sidebar header icons #19934
Conversation
|
@dougfabris do you think it would be a good idea to replace the sort icon with something more intuitive since it represents more than just sort (for example, view modes and group by)? Would love to hear your thoughts on this. |
dougfabris
left a comment
dougfabris
left a comment
There was a problem hiding this comment.
@dougfabris do you think it would be a good idea to replace the sort icon with something more intuitive since it represents more than just sort (for example, view modes and group by)? Would love to hear your thoughts on this.
Well, for now, we shouldn't replace the icon. Just replace the title for Filters, I think it can be more descriptive.
RonLek
force-pushed
the
sidenav_header_tooltip
branch
from
0c5468b to
139d590
Compare
|
Thanks! @dougfabris. Made the changes. |
|
@RonLek Thank you for helping us =) |
ggazzo
left a comment
ggazzo
left a comment
There was a problem hiding this comment.
hey thanks for your time, can I ask you to use translations instead of the raw text?
look for useTranslation
|
@RonLek as these translations are related to the fix I think it's not a problem to add in this PR. |
RonLek
force-pushed
the
sidenav_header_tooltip
branch
from
af4db77 to
e88fda2
Compare
|
Thanks! @dougfabris . Added translations in this PR itself : ) |
|
@dougfabris @ggazzo do let me know if any changes required. Even though the translations are double-checked should translations be done only in English for the time being in this PR since we're taking in native speakers' contributions for translations? Awaiting your views on this one : ) |
|
@RonLek I would ask you to do not create one more key, please use |
RonLek
force-pushed
the
sidenav_header_tooltip
branch
from
e88fda2 to
66ab999
Compare
Lint fix Adds tooltip for sidebar header icons Modifies Sort and CreateRoom titles Adds translations for sidenav header icons Fixes lint Uses translations for sidenav header icons Uses translations for sidenav header icons Uses Create_A_New_Channel instead of creating Create_Room Rebases with develop
RonLek
force-pushed
the
sidenav_header_tooltip
branch
from
0a6a642 to
c2056cd
Compare
|
Thanks @ggazzo. I've made the changes. Please review. |
|
@dougfabris @ggazzo please take a look :) |
|
@RonLek can I ask you from where did you get the translations? I'm not very fluent in some of them :p just to be sure that makes sense |
|
@ggazzo Definitely! All of the translations have been taken up from Google Translate after a double-check. What I mean by a double-check is that if "Home" translates to "Casa" in Spanish, then I've reverse translated "Casa" to English and seen if that checks out back to "Home" and only then inserted the translation for the word (skipped in cases it didn't). The reason for this is that I'm aware Google Translate might not capture the context of the word when just a single word is entered for translation but doing a reverse-check confirms if the translation was correct. Let me know what you think : ) |
|
Ok, |
3 participants
Proposed changes (including videos or screenshots)
Previously the header icons in the sidebar didn't show a tooltip when hovered over. This PR fixes that.
Issue(s)
Closes #19908