[FIX] Invalid filters on the Omnichannel Analytics page #19899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix layout not rendering properly - handle some edge cases for date select
rafaelblink
previously approved these changes
Dec 18, 2020
Contributor
rafaelblink
left a comment
rafaelblink
left a comment
There was a problem hiding this comment.
Everything working well.
renatobecker
requested changes
Dec 21, 2020
Contributor
There was a problem hiding this comment.
@murtaza98 this is the design expected.
I'm still getting errors on server-side, BTW:
I20201221-18:35:31.564(-3)? Incorrect chart options
I20201221-18:35:31.571(-3)? livechat:getAnalyticsOverviewData => Invalid dates
I20201221-18:35:31.576(-3)? Incorrect analytics options
…hub.com/RocketChat/Rocket.Chat into omnichannel/fix-analytics-page-layout-1
renatobecker
requested changes
Jan 13, 2021
Contributor
|
@murtaza98 I'm still facing this inconsistency
|
Contributor
Author
@renatobecker This bug hasn't been fixed yet. I wasn't able to determine the issue 😞 . I'll still need to do some more debugging specifically with mongo queries. |
renatobecker
approved these changes
Jan 14, 2021
renatobecker
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Fix layout not rendering properly. Following was the layout which was getting rendered
BEFORE
AFTER
Handle some edge cases for date select
This Month, then it should set the end date to current date instead of the last date of the monthdate.toISOString(), under my timezone it was converting start of the month incorrectly. I expected it to be 1st December however it converts it to 30st November. Please have a look in the below consoleTo solve 🔝 error, I've converted the code to use
momentlibrary.Steps to test or reproduce
Further comments
Server version: In sync with latest develop branch