Skip to content

Regression: Prevent network broker from starting when not needed #19532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sampaiodiego merged 2 commits into from
Nov 14, 2020
Merged

Regression: Prevent network broker from starting when not needed #19532

sampaiodiego merged 2 commits into from
Nov 14, 2020

Conversation

@sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Nov 14, 2020

Proposed changes

Network broker was starting when not really needed. So now it requires the TRANSPORTER env var to be set.

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@sampaiodiego sampaiodiego added this to the 3.8.0 milestone Nov 14, 2020
rodrigok
rodrigok previously approved these changes Nov 14, 2020
View reviewed changes
@sampaiodiego sampaiodiego changed the title Regression: Prevent network from starting when not needed Regression: Prevent network broker from starting when not needed Nov 14, 2020
@sampaiodiego sampaiodiego merged commit e0e068f into develop Nov 14, 2020
@sampaiodiego sampaiodiego deleted the not-start-network-broker branch November 14, 2020 02:30
@sampaiodiego sampaiodiego mentioned this pull request Nov 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggazzo ggazzo ggazzo approved these changes

@rodrigok rodrigok rodrigok left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.8.0

Development

Successfully merging this pull request may close these issues.

4 participants

@sampaiodiego @rodrigok @ggazzo