Skip to content

Regression: Fix broadcast events when running as monolith #19498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sampaiodiego merged 11 commits into from
Nov 12, 2020
Merged

Regression: Fix broadcast events when running as monolith #19498

sampaiodiego merged 11 commits into from
Nov 12, 2020

Conversation

@sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Nov 10, 2020

Proposed changes

Notify user status to all instances as it was before the micro services implementation.

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@sampaiodiego sampaiodiego added this to the 3.8.0 milestone Nov 10, 2020
@lgtm-com
Copy link

lgtm-com bot commented Nov 11, 2020

This pull request introduces 1 alert when merging 5b39523 into 4b68fb9 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

rodrigok
rodrigok reviewed Nov 11, 2020
View reviewed changes
rodrigok
rodrigok reviewed Nov 11, 2020
View reviewed changes
@sampaiodiego sampaiodiego changed the title Regression: Notify user status to all instances Regression: Fix broadcast events when running as monolith Nov 12, 2020
rodrigok
rodrigok previously approved these changes Nov 12, 2020
View reviewed changes
@sampaiodiego sampaiodiego force-pushed the fix-presence-broadcast branch from d07bc75 to 6e39fcb Compare November 12, 2020 18:37
@sampaiodiego sampaiodiego merged commit 48af214 into develop Nov 12, 2020
@sampaiodiego sampaiodiego deleted the fix-presence-broadcast branch November 12, 2020 19:51
@sampaiodiego sampaiodiego mentioned this pull request Nov 14, 2020
Merged
@emikolajczak emikolajczak mentioned this pull request Jun 7, 2021
Open
@emikolajczak emikolajczak mentioned this pull request Jun 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rodrigok rodrigok rodrigok approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.8.0

Development

Successfully merging this pull request may close these issues.

3 participants

@sampaiodiego @rodrigok