Skip to content

Remove unecessary return at the send code api #19494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sampaiodiego merged 1 commit into from
Nov 10, 2020
+4 −4
Merged

Remove unecessary return at the send code api #19494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions app/2fa/server/code/EmailCheck.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ ${ t('If_you_didnt_try_to_login_in_your_account_please_ignore_this_email') }
return !!valid;
}

public sendEmailCode(user: IUser): string[] {
public sendEmailCode(user: IUser): void {
const emails = this.getUserVerifiedEmails(user);
const random = Random._randomString(6, '0123456789');
const encryptedRandom = bcrypt.hashSync(random, Accounts._bcryptRounds());
Expand All @@ -108,8 +108,6 @@ ${ t('If_you_didnt_try_to_login_in_your_account_please_ignore_this_email') }
for (const address of emails) {
this.send2FAEmail(address, random, user);
}

return emails;
}

public processInvalidCode(user: IUser): IProcessInvalidCodeResult {
Expand Down
4 changes: 3 additions & 1 deletion app/api/server/v1/users.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,7 +720,9 @@ API.v1.addRoute('users.2fa.sendEmailCode', {
throw new Meteor.Error('error-invalid-user', 'Invalid user');
}

return API.v1.success(emailCheck.sendEmailCode(getUserForCheck(userId)));
emailCheck.sendEmailCode(getUserForCheck(userId));

return API.v1.success();
},
});

Expand Down