Skip to content

Conversation

@sampaiodiego
Copy link
Member

Proposed changes

The problem was that the function EnterpriseSettings.changeSettingValue returns undefined if the setting is not an enterprise setting but the code was always replacing the property value with its return, causing the value not being sent through setting streamers.

Issue(s)

How to test or reproduce

  • Open network tab on browser
  • Go to Admin and change a setting
  • You should receive a public-settings-changed or private-settings-changed without the value property.

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@sampaiodiego sampaiodiego added this to the 3.8.0 milestone Nov 8, 2020
@sampaiodiego sampaiodiego merged commit 22ca1e1 into develop Nov 9, 2020
@sampaiodiego sampaiodiego deleted the regression-setting-value-not-sent branch November 9, 2020 12:17
@sampaiodiego sampaiodiego mentioned this pull request Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants