Skip to content

Conversation

@sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Nov 5, 2020

Proposed changes

The new permission validation functions created on the micro services were not properly validating livechat calls that doesn't have an authenticated user, so I had to turn those params as optional and validate them on every "canAccessRoom validator".

This is supposed to fix:

  • All livechat actions such as:
    • typing
    • message receiving
    • file upload
    • notifications

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@sampaiodiego sampaiodiego added this to the 3.8.0 milestone Nov 5, 2020
@sampaiodiego sampaiodiego merged commit e7b4fef into develop Nov 6, 2020
@sampaiodiego sampaiodiego deleted the fix-livechat-permission-validations branch November 6, 2020 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants