Skip to content

Micro Services: Add metrics capability to Services #19448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rodrigok merged 5 commits into from
Nov 3, 2020
Merged

Micro Services: Add metrics capability to Services #19448

rodrigok merged 5 commits into from
Nov 3, 2020

Conversation

@sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Nov 3, 2020 •
edited
Loading

Proposed changes

Implement an interface for services to register metrics.

metrics property is optional to interface IBroker for now, so it was implemented only on NetworkBroker that is currently using it.. LocalBroker doesn't have it, we can figure something out later the better way to implement in both brokers.

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@sampaiodiego sampaiodiego requested a review from rodrigok November 3, 2020 20:35
@rodrigok rodrigok changed the title Add metrics capability to Services Micro Services: Add metrics capability to Services Nov 3, 2020
@sampaiodiego sampaiodiego marked this pull request as ready for review November 3, 2020 21:45
@rodrigok rodrigok merged commit 30df229 into develop Nov 3, 2020
@rodrigok rodrigok deleted the service-metrics branch November 3, 2020 22:15
@sampaiodiego sampaiodiego mentioned this pull request Nov 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rodrigok rodrigok rodrigok approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sampaiodiego @rodrigok