Micro Services: Create internal services and allowed services list #19427
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
I'm proposing a way to control if a service should be registered on network broker of rocket.chat instances, which can be controlled via two different env vars:
INTERNAL_SERVICES_ONLY(defaultfalse) - if set totruerocket.chat will register only internal services, that are services that only rocket.chat instances have the information to respond or emit events, i.e.:meteor-serviceSERVICES_ALLOWED(defaultempty) - a comma separated list of services that when set will control which service will be registered on the rocket.chat instance, it has precedence over theINTERNAL_SERVICES_ONLYwhich means if you setINTERNAL_SERVICES_ONLY=authorizationit will not even startmeteor-serviceServices are considered "external" by default, which means they're by default designed to run as standalone. Maybe the flag should be called
standalone, wdyt?Issue(s)
How to test or reproduce
Screenshots
Types of changes
Checklist
Changelog
Further comments