Skip to content

Conversation

@sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Nov 1, 2020

Proposed changes

I'm proposing a way to control if a service should be registered on network broker of rocket.chat instances, which can be controlled via two different env vars:

  • INTERNAL_SERVICES_ONLY (default false) - if set to true rocket.chat will register only internal services, that are services that only rocket.chat instances have the information to respond or emit events, i.e.: meteor-service
  • SERVICES_ALLOWED (default empty) - a comma separated list of services that when set will control which service will be registered on the rocket.chat instance, it has precedence over the INTERNAL_SERVICES_ONLY which means if you set INTERNAL_SERVICES_ONLY=authorization it will not even start meteor-service

Services are considered "external" by default, which means they're by default designed to run as standalone. Maybe the flag should be called standalone, wdyt?

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Improvement (non-breaking change which improves a current function)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

rodrigok
rodrigok previously approved these changes Nov 2, 2020
@rodrigok rodrigok changed the title Create internal services and allowed services list Micro Services: Create internal services and allowed services list Nov 2, 2020
@rodrigok rodrigok added this to the 3.8.0 milestone Nov 2, 2020
@rodrigok rodrigok merged commit 556cc51 into develop Nov 2, 2020
@rodrigok rodrigok deleted the implement-internal-services branch November 2, 2020 17:03
@sampaiodiego sampaiodiego mentioned this pull request Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants