Skip to content

Conversation

@thassiov
Copy link
Contributor

@thassiov thassiov commented Oct 30, 2020

Proposed changes

Enables apps to run tasks without the need for manually scheduling them. By passing a config object with the job processor definition (startupSetting), the job will be scheduled to run right after being registered.

This is what makes it possible for apps to schedule Jobs within the "Initialization" phase, without the need for user input. It wasn't previously possible due to the fact that a modifier was required to schedule jobs, but no modifiers are allowed in the "Initialization" phase (it can be potentially problematic in HA setups).

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@thassiov thassiov requested review from d-gubert and shiqimei October 30, 2020 15:10
@thassiov thassiov changed the title [IMPROVE][APPS] Automate job scheduling by passing configs with processor definition [IMPROVEMENT][APPS] Automate job scheduling by passing configs with processor definition Nov 3, 2020
@thassiov thassiov requested a review from d-gubert November 4, 2020 14:22
@d-gubert d-gubert added this to the 3.8.0 milestone Nov 4, 2020
Copy link
Member

@d-gubert d-gubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've approved before but the apps-engine version hasn't been updated yet

@d-gubert d-gubert changed the title [IMPROVEMENT][APPS] Automate job scheduling by passing configs with processor definition Regression: Allow apps to schedule jobs along with processor register Nov 5, 2020
@d-gubert d-gubert force-pushed the impr/run-job-after-register branch from f9657a4 to 13cce23 Compare November 9, 2020 19:02
@sampaiodiego sampaiodiego merged commit 933b67f into develop Nov 9, 2020
@sampaiodiego sampaiodiego deleted the impr/run-job-after-register branch November 9, 2020 23:27
@sampaiodiego sampaiodiego mentioned this pull request Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants