Skip to content

Regression: Thread list misbehaving #19413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ggazzo merged 6 commits into from
Nov 4, 2020
Merged

Regression: Thread list misbehaving #19413

ggazzo merged 6 commits into from
Nov 4, 2020

Conversation

@tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Oct 29, 2020 •
edited
Loading

Proposed changes

It fixes "duplicated" entries (actually, edited messages kept as history) and flickering.

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@tassoevan tassoevan added this to the 3.8.0 milestone Oct 29, 2020
@tassoevan tassoevan requested review from a team and sampaiodiego October 30, 2020 13:43
@tassoevan tassoevan changed the title regression/thread-list Regression: Thread list misbehaving Oct 30, 2020
@tassoevan tassoevan marked this pull request as ready for review October 30, 2020 14:26
@ggazzo ggazzo merged commit 65fabc1 into develop Nov 4, 2020
@ggazzo ggazzo deleted the regression/thread-list branch November 4, 2020 14:28
@sampaiodiego sampaiodiego mentioned this pull request Nov 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggazzo ggazzo ggazzo approved these changes

@sampaiodiego sampaiodiego Awaiting requested review from sampaiodiego

Assignees

No one assigned

Labels

feat: threads / discussions Threads and Discussions type: regression

Projects

None yet

Milestone

3.8.0

Development

Successfully merging this pull request may close these issues.

4 participants

@tassoevan @ggazzo @tiagoevanp