Skip to content

Conversation

@tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Oct 28, 2020

Proposed changes

  • Does NOT ignore that the initial state of message could be undefined;
  • Convert message._updatedAt type from REST API from string to Date;
  • Checks _id and _updatedAt to bail-out re-renderings;
  • Pass data to the thread template without reactivity.

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@tassoevan tassoevan added this to the 3.8.0 milestone Oct 28, 2020
@tassoevan tassoevan requested a review from a team October 28, 2020 06:34
@tassoevan tassoevan marked this pull request as ready for review October 28, 2020 06:39
Copy link
Member

@gabriellsh gabriellsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@tassoevan tassoevan merged commit 03a55bb into develop Oct 28, 2020
@tassoevan tassoevan deleted the regression/thread-component branch October 28, 2020 14:59
@sampaiodiego sampaiodiego mentioned this pull request Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants