[NEW] Replace client-side event emitters #19368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagoevanp
force-pushed
the
feat/replace-emitter
branch
from
73bb927 to
55fc22c
Compare
tiagoevanp
force-pushed
the
feat/replace-emitter
branch
from
55fc22c to
7143055
Compare
gabriellsh
requested changes
Oct 26, 2020
Member
gabriellsh
left a comment
gabriellsh
left a comment
There was a problem hiding this comment.
Hey! You're missing the following file client/contexts/AuthorizationContext.ts and removing the following package: @types/wolfy87-eventemitter. Please update the package-lock too.
Contributor
Author
|
You're right @gabriellsh. Can you please review it again now? |
gabriellsh
previously approved these changes
Oct 26, 2020
tassoevan
requested changes
Oct 27, 2020
Co-authored-by: Tasso Evangelista <[email protected]>
…nto feat/replace-emitter
tassoevan
approved these changes
Oct 27, 2020
tassoevan
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Replace emitter imports with @rocket.chat/emitter
Issue(s)
Closes #19372
How to test or reproduce
Screenshots
Types of changes
Checklist
Changelog
Further comments