Skip to content

Conversation

@pierre-lehnen-rc
Copy link
Contributor

@pierre-lehnen-rc pierre-lehnen-rc commented Oct 22, 2020

Proposed changes

Issue(s)

Closes #19058
Closes #18330

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@pierre-lehnen-rc pierre-lehnen-rc added this to the 3.8.0 milestone Oct 22, 2020
@sampaiodiego sampaiodiego merged commit 66e6ec3 into develop Oct 23, 2020
@sampaiodiego sampaiodiego deleted the fix.ldap-dup-key branch October 23, 2020 21:36
@sampaiodiego sampaiodiego mentioned this pull request Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LDAP Sync Error Dup Key on Rocket.chat 3.6.3 LDAP import identities - Not work

4 participants