Skip to content

Regression: User card closing #19322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ggazzo merged 2 commits into from
Oct 21, 2020
Merged

Regression: User card closing #19322

ggazzo merged 2 commits into from
Oct 21, 2020

Conversation

@tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Oct 21, 2020

Proposed changes

The user card, shown when a username is clicked, was not opening... because it was closing right after opening. 😬

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@tassoevan tassoevan added area: ui Touches the code on client side type: regression labels Oct 21, 2020
@tassoevan tassoevan added this to the 3.8.0 milestone Oct 21, 2020
@tassoevan tassoevan requested a review from a team October 21, 2020 22:50
@ggazzo ggazzo merged commit f44af14 into develop Oct 21, 2020
@ggazzo ggazzo deleted the fix/user-card-closing branch October 21, 2020 23:46
thassiov pushed a commit that referenced this pull request Oct 23, 2020
@tassoevan @thassiov
Regression: User card closing (#19322)
3a8bd4b
@sampaiodiego sampaiodiego mentioned this pull request Nov 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggazzo ggazzo ggazzo approved these changes

Assignees

No one assigned

Labels

area: ui Touches the code on client side type: regression

Projects

None yet

Milestone

3.8.0

Development

Successfully merging this pull request may close these issues.

3 participants

@tassoevan @ggazzo