Skip to content

Conversation

@ggazzo
Copy link
Member

@ggazzo ggazzo commented Oct 21, 2020

Proposed changes

One more helper/context/hook, helping us to remove the roomTypes dependency and Isolate the components

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@ggazzo ggazzo changed the title [NEW] React Avatar Provider [IMPROVE] React Avatar Provider Oct 21, 2020
@lgtm-com
Copy link

lgtm-com bot commented Oct 21, 2020

This pull request introduces 1 alert when merging 39633c5 into 1e7b31d - view on LGTM.com

new alerts:

  • 1 for Syntax error

@lgtm-com
Copy link

lgtm-com bot commented Oct 21, 2020

This pull request introduces 1 alert when merging c21e70f into 1e7b31d - view on LGTM.com

new alerts:

  • 1 for Syntax error

@ggazzo ggazzo merged commit e416a32 into develop Oct 22, 2020
@ggazzo ggazzo deleted the avatar-provider branch October 22, 2020 02:07
thassiov pushed a commit that referenced this pull request Oct 23, 2020
@sampaiodiego sampaiodiego mentioned this pull request Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants