Skip to content

[FIX] Message actions on top of text #19316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tassoevan merged 2 commits into from
Oct 22, 2020
Merged

[FIX] Message actions on top of text #19316

tassoevan merged 2 commits into from
Oct 22, 2020

Conversation

@gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Oct 21, 2020

Proposed changes

Issue(s)

How to test or reproduce

Screenshots

image
image

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@gabriellsh gabriellsh added the area: ui Touches the code on client side label Oct 21, 2020
@gabriellsh gabriellsh requested a review from a team October 21, 2020 13:34
MartinSchoeler
MartinSchoeler approved these changes Oct 21, 2020
View reviewed changes
Copy link
Member

@MartinSchoeler MartinSchoeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@tassoevan tassoevan merged commit dea4551 into develop Oct 22, 2020
@tassoevan tassoevan deleted the msg-btn-style branch October 22, 2020 00:42
thassiov pushed a commit that referenced this pull request Oct 23, 2020
@gabriellsh @tassoevan @thassiov
[FIX] Message actions on top of text (#19316)
2c005f9 
Co-authored-by: Tasso Evangelista <[email protected]>
@sampaiodiego sampaiodiego mentioned this pull request Nov 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tassoevan tassoevan tassoevan approved these changes

@MartinSchoeler MartinSchoeler MartinSchoeler approved these changes

Assignees

No one assigned

Labels

area: ui Touches the code on client side

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gabriellsh @tassoevan @MartinSchoeler