Skip to content

Conversation

@kto2038
Copy link

@kto2038 kto2038 commented Oct 17, 2020

Proposed changes

Remove superfluous spaces in triggerWords.

Issue(s)

Closes #17820

On editing Outgoing WebHook, #17820 was fixed by #17830 .
On creating Outgoing WebHook, #17820 isn't fixed yet.

How to test or reproduce

See #17820

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Remove spaces between the trigger words (;) when creating the outgoing webhook.

Further comments

@kto2038 kto2038 marked this pull request as ready for review October 17, 2020 08:31
@CLAassistant
Copy link

CLAassistant commented Dec 17, 2021

CLA assistant check
All committers have signed the CLA.

@dougfabris dougfabris changed the title [FIX] Fix triggerWords splitting on creating Outgoing WebHook (#17820) [FIX] Fix triggerWords splitting on creating Outgoing WebHook Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

Outgoing WebHook doesn't work when Trigger Words is empty

5 participants