Reassessment of client helpers #19249
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Client-side code relies on some helper functions aiming reusability but over time some duplication is expected. As highlights here:
Blobobjects and properly escaping CSV data;client/helpers/was dropped in favor ofclient/lib/;RegExp.escapewas replaced only in client byescapeRegExp, to avoid global namespace pollution.capitalize()was kept only becauseuseForm()heavily depends on it.Issue(s)
How to test or reproduce
Screenshots
Types of changes
Checklist
Changelog
Further comments