Skip to content

Conversation

@cyberquill
Copy link
Contributor

Proposed changes

README updated to reflect the currently followed procedure for opening a new feature request. The old link present in the document is described accordingly, as it is now only used for historical purposes.

Issue(s)

How to test or reproduce

Screenshots

Screenshot (26)

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@cyberquill
Copy link
Contributor Author

cyberquill commented Oct 14, 2020

#Hacktoberfest brought me here. This is my first open-source contribution! Super excited to get started!🤘😊
@ggazzo please have a look, and advice me accordingly...

@cyberquill cyberquill closed this Oct 21, 2020
@cyberquill cyberquill reopened this Oct 21, 2020
@cyberquill
Copy link
Contributor Author

@ggazzo @tassoevan @sampaiodiego Can you please review my updates? I am hoping to get this PR accepted for #Hacktoberfest. So, it would really mean a lot if the PR gets reviewed before October-end. Hoping to hear from you soon : )

geekgonecrazy
geekgonecrazy previously approved these changes Oct 25, 2020
@sampaiodiego sampaiodiego changed the title [FIX] README updated with the current feature-request opening process. Update feature-request opening process on README Oct 26, 2020
@sampaiodiego sampaiodiego merged commit 307a610 into RocketChat:develop Oct 26, 2020
@sampaiodiego sampaiodiego mentioned this pull request Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants