Skip to content

Conversation

@tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Oct 9, 2020

Proposed changes

Some modules have more than one component, which is not recommended for maintenance. By extracting those components, we can avoid duplication (e.g. modals and filters). Additionally some components were rewritten in TypeScript and Fuselage typings were updated.

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@tassoevan tassoevan changed the title perf/components Refactor some components (1st iteration) Oct 13, 2020
@tassoevan tassoevan requested a review from a team October 13, 2020 11:51
@tassoevan tassoevan added area: ui Touches the code on client side type: improvement labels Oct 13, 2020
@tassoevan tassoevan added this to the 3.8.0 milestone Oct 13, 2020
@tassoevan tassoevan marked this pull request as ready for review October 13, 2020 12:21
@ggazzo ggazzo changed the title Refactor some components (1st iteration) Refactor some components React Page and components Oct 13, 2020
@ggazzo ggazzo changed the title Refactor some components React Page and components Refactor some React Pages and Components Oct 13, 2020
@ggazzo ggazzo merged commit fe0c27a into develop Oct 13, 2020
@ggazzo ggazzo deleted the perf/components branch October 13, 2020 15:08
@sampaiodiego sampaiodiego mentioned this pull request Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ui Touches the code on client side type: improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants