Skip to content

[FIX] Omnichannel auditing required field #19201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggazzo merged 1 commit into from
Oct 13, 2020
Merged

[FIX] Omnichannel auditing required field #19201

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions ee/client/audit/AuditPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const initialValues = {
end: '',
},
visitor: '',
agent: '',
agent: 'all',
rid: '',
users: [],
};
Expand Down Expand Up @@ -86,12 +86,8 @@ const AuditPage = () => {
if (type === 'l') {
const errors = {};

if (visitor === '') {
errors.visitor = t('The_field_is_required', t('Visitor'));
}

if (agent === '') {
errors.visitor = t('The_field_is_required', t('Agent'));
errors.agent = t('The_field_is_required', t('Agent'));
}

if (errors.visitor || errors.agent) {
Expand Down Expand Up @@ -159,7 +155,7 @@ const AuditPage = () => {
{type === 'l' && <Box display='flex' flexDirection='row' w='full' mi='neg-x4'>
<Margins inline='x4'>
<Field>
<Field.Label>{t('Visitor')}</Field.Label>
<Field.Label flexGrow={0}>{t('Visitor')}</Field.Label>
<Field.Row>
<VisitorAutoComplete error={errors.visitor} value={visitor} onChange={handleVisitor} placeholder={t('Username_Placeholder')}/>
</Field.Row>
Expand All @@ -168,7 +164,7 @@ const AuditPage = () => {
</Field.Error>}
</Field>
<Field>
<Field.Label>{t('Agent')}</Field.Label>
<Field.Label flexGrow={0}>{t('Agent')}</Field.Label>
<Field.Row>
<AutoCompleteAgent error={errors.agent} value={agent} onChange={handleAgent} placeholder={t('Username_Placeholder')}/>
</Field.Row>
Expand Down