Skip to content

[FIX] Adding missing custom fields translation in my account's profile #19179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sampaiodiego merged 1 commit into from
Oct 9, 2020
Merged

[FIX] Adding missing custom fields translation in my account's profile #19179

sampaiodiego merged 1 commit into from
Oct 9, 2020

Conversation

@dougfabris
Copy link
Member

@dougfabris dougfabris commented Oct 8, 2020

Proposed changes

Issue(s)

Closes #19144

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@dougfabris dougfabris added the area: ui Touches the code on client side label Oct 8, 2020
@dougfabris dougfabris added this to the 3.7.1 milestone Oct 8, 2020
@dougfabris dougfabris requested review from a team and gabriellsh October 8, 2020 16:14
@sampaiodiego sampaiodiego merged commit 0351814 into develop Oct 9, 2020
@sampaiodiego sampaiodiego deleted the fix/user_settings branch October 9, 2020 03:11
sampaiodiego pushed a commit that referenced this pull request Oct 9, 2020
@sampaiodiego
[FIX] Adding missing custom fields translation in my account's profile (
d6b7675 
#19179)
@sampaiodiego sampaiodiego mentioned this pull request Oct 9, 2020
Merged
@bkraul bkraul mentioned this pull request Oct 16, 2020
Closed
@sampaiodiego sampaiodiego mentioned this pull request Nov 14, 2020
Merged
@kulla kulla mentioned this pull request Apr 21, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggazzo ggazzo ggazzo approved these changes

@gabriellsh gabriellsh gabriellsh approved these changes

Assignees

No one assigned

Labels

area: ui Touches the code on client side

Projects

None yet

Milestone

3.7.1

Development

Successfully merging this pull request may close these issues.

Translation does not work

5 participants

@dougfabris @ggazzo @gabriellsh @sampaiodiego