Skip to content

[FIX] Error when editing priority and required description #19170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggazzo merged 1 commit into from
Oct 7, 2020
Merged

[FIX] Error when editing priority and required description #19170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions ee/client/omnichannel/priorities/EditPriority.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export function PriorityEditWithData({ priorityId, reload }) {
return <FormSkeleton/>;
}

if (error || !data || !data.priorities) {
if (error || !data) {
return <Callout m='x16' type='danger'>{t('Not_Available')}</Callout>;
}

Expand Down Expand Up @@ -53,7 +53,6 @@ export function PriorityEdit({ data, isNew, priorityId, reload, ...props }) {
} = values;

const nameError = useMemo(() => (!name || name.length === 0 ? t('The_field_is_required', 'name') : undefined), [name, t]);
const descriptionError = useMemo(() => (!description || description.length === 0 ? t('The_field_is_required', 'description') : undefined), [description, t]);
const dueTimeInMinutesError = useMemo(() => (!dueTimeInMinutes || dueTimeInMinutes <= 0 ? t('The_field_is_required', 'Estimated_due_time_in_minutes') : undefined), [dueTimeInMinutes, t]);

const savePriority = useMethod('livechat:savePriority');
Expand All @@ -64,7 +63,7 @@ export function PriorityEdit({ data, isNew, priorityId, reload, ...props }) {
reload();
});

const canSave = useMemo(() => !nameError && !descriptionError && !dueTimeInMinutesError, [nameError, descriptionError, dueTimeInMinutesError]);
const canSave = useMemo(() => !nameError && !dueTimeInMinutesError, [nameError, dueTimeInMinutesError]);

const handleSave = useMutableCallback(async () => {
const payload = { name, description, dueTimeInMinutes: `${ dueTimeInMinutes }` };
Expand Down Expand Up @@ -93,7 +92,7 @@ export function PriorityEdit({ data, isNew, priorityId, reload, ...props }) {
<Field>
<Field.Label>{t('Description')}</Field.Label>
<Field.Row>
<TextInput flexGrow={1} value={description} onChange={handleDescription} error={hasUnsavedChanges && descriptionError} />
<TextInput flexGrow={1} value={description} onChange={handleDescription} />
</Field.Row>
</Field>
<Field>
Expand Down